Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect highlight color #12190

Closed
slavizh opened this issue Oct 18, 2023 · 2 comments · Fixed by #12199
Closed

Incorrect highlight color #12190

slavizh opened this issue Oct 18, 2023 · 2 comments · Fixed by #12199
Labels
Needs: Triage 🔍

Comments

@slavizh
Copy link
Contributor

slavizh commented Oct 18, 2023 •
edited
Loading

Bicep version
Bicep CLI version 0.22.6 (d62b94d)

Describe the bug
If you have the code below the type (where we have 'SystemAssigned' | 'SystemAssigned, UserAssigned' | 'None' | '') is incorrectly highlighted in purple color just like the type identityOutput . It should be blue in this case.

type identityOutput = {
  @description('Some description')
  type: 'SystemAssigned' | 'SystemAssigned, UserAssigned' | 'None' | ''
  principalId: string
  tenantId: string
}

To Reproduce
Steps to reproduce the behavior:

Additional context
Add any other context about the problem here.
@slavizh slavizh changed the title Incorrect highligh color Incorrect highlight color Oct 18, 2023
@slavizh
Copy link
Contributor Author

slavizh commented Oct 19, 2023

happens as soon as you put description on top of type.

@anthony-c-martin
Copy link
Member

This should be straightforward to fix - looks like we're just missing implementation for some of the *TypeSyntax nodes here: https://github.com/Azure/bicep/blob/main/src/Bicep.LangServer/SemanticTokenVisitor.cs

@anthony-c-martin anthony-c-martin mentioned this issue Oct 19, 2023
Merged
anthony-c-martin added a commit that referenced this issue Oct 19, 2023
@anthony-c-martin
Publish semantic tokens for object type keys (#12199)
4137ecc 
Closes #12190
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/12199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs: Triage 🔍
Projects
Bicep
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish semantic tokens for object type keys Azure/bicep
2 participants
@slavizh @anthony-c-martin