Fix vscode e2e tests #13906
Merged
Fix vscode e2e tests #13906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this change out locally with the following install scripts (Action run 8760742897) VSCode
Azure CLI
|
StephenWeatherford
force-pushed
the
sw/fix-vscode-e2e
branch
from
0e4cbab
to
4be47f0
Compare
| let result = cp.spawnSync(cliPath, extensionInstallArguments, { | ||
| encoding: "utf-8", | ||
| stdio: "inherit", | ||
| shell: true, |
There was a problem hiding this comment.
This "shell: true" is the actual fix, the rest is formatting or debugging info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by a bug in node 18 and 20 which were caused by recent security fixes, see node-red/node-red#4652. Short version, it's no longer valid to use spawnSync without"shell:true".
Microsoft Reviewers: Open in CodeFlow