Fix use of spawn on windows with cmd files #4652
Merged
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2024
Closed
Steve-Mcl
approved these changes
Apr 11, 2024
This was referenced Apr 11, 2024
Closed
This was referenced Apr 16, 2024
pengx17
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Apr 16, 2024
a workaround for spawn EINVAL error. Found this issue according to node-red/node-red#4652 ~~In our case the electron app is spawned by playwright. I am still investigating the issue but don't know how long it takes.~~ Upstream fix: microsoft/playwright#30382
fannheyward
added a commit
to neoclide/coc.nvim
that referenced
this pull request
Apr 19, 2024
Closes neoclide/coc-prettier#178 Latest version of Node.js needs to set `shell: true` to spawn option - node-red/node-red#4652 - microsoft/rushstack#4637
fannheyward
added a commit
to neoclide/coc.nvim
that referenced
this pull request
Apr 19, 2024
Closes neoclide/coc-prettier#178 Latest version of Node.js needs to set `shell: true` to spawn option - node-red/node-red#4652 - microsoft/rushstack#4637
StephenWeatherford
added a commit
to Azure/bicep
that referenced
this pull request
Apr 19, 2024
Caused by a bug in node 18 and 20 which were caused by recent security fixes, see node-red/node-red#4652. Short version, it's no longer valid to use spawnSync without"shell:true". ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13906)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the 18.20.2/20.12.2 node.js releases, it is no longer valid to call
child_process.spawnwith a.cmdor.batfile without using theshell: trueoption.This PR updates our usage to include the
shelloption when appropriate.It's hard to know exactly what impact this could have given the many and varied ways the exec node is used - so will need some testing to verify.