Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blinQ - Add resource type public ip prefix #341

Merged
merged 1 commit into from
Apr 20, 2022
Merged

blinQ - Add resource type public ip prefix #341

merged 1 commit into from
Apr 20, 2022

Conversation

heintonny
Copy link
Contributor

@heintonny heintonny commented Mar 27, 2022

Issue-id

PR Checklist


  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Created Super Module logic for resource public ip prefix. Public IP prefix can be refrenced from public ip resouce and remote states. Depends on aztfmod/terraform-azurerm-caf#1049

Does this introduce a breaking change

  • YES
  • NO

Testing

Need some guiding in how to develop the automated test, but we have run manually tests from local VS. Is it Main branch or aci_network how is the primary branch for this repository?

@ghost
Copy link

ghost commented Mar 27, 2022

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurentLesle
Copy link
Contributor

@heintonny can you agree the CLA? Need it to merge your change

@arnaudlh arnaudlh added the 5.5.6 label Apr 19, 2022
@arnaudlh arnaudlh modified the milestones: 2109, 2204 Apr 20, 2022
@arnaudlh arnaudlh merged commit c16cbe8 into Azure:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants