Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding public ip prefixes #1049

Merged
merged 6 commits into from
Apr 4, 2022
Merged

Conversation

heintonny
Copy link
Contributor

Issue-id

PR Checklist


Description

Created module for public ip prefix and logic to reference public ip prefix from remote states.

Does this introduce a breaking change

  • YES
  • NO

Testing

Created example configuration networking/pip_prefix and updated standalone-scenarios.json.

@heintonny heintonny changed the title blinQ - Created module for resource typ public ip prefix blinQ - Created module for resource type public ip prefix Mar 27, 2022
@arnaudlh arnaudlh added this to In progress in Milestone 2204 via automation Apr 4, 2022
@arnaudlh arnaudlh modified the milestone: 5.5.6 Apr 4, 2022
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added:

  1. FMT
  2. Example variables
  3. Refactored the resource locator for public ip address to be more reliable at plan time:
 public_ip_prefix_id        = can(each.value.public_ip_prefix.key) ? local.combined_objects_public_ip_prefixes[try(each.value.public_ip_prefix.lz_key, local.client_config.landingzone_key)][each.value.public_ip_prefix.key].id : try(each.value.public_ip_prefix_id, null)

Milestone 2204 automation moved this from In progress to Reviewer approved Apr 4, 2022
@arnaudlh arnaudlh changed the title blinQ - Created module for resource type public ip prefix Adding public ip prefixes Apr 4, 2022
arnaudlh added a commit that referenced this pull request Apr 4, 2022
@arnaudlh arnaudlh merged commit 79da2bb into aztfmod:main Apr 4, 2022
Milestone 2204 automation moved this from Reviewer approved to Done Apr 4, 2022
@arnaudlh
Copy link
Member

arnaudlh commented Apr 4, 2022

thanks for your contributation to CAF @heintonny and BlinQ AS!

@heintonny heintonny deleted the blinq-public-ip-prefix branch March 9, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants