Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventFlow fails when contenerized app is debugged using Visual Studio Docker tools #139

Closed
karolz-ms opened this issue Oct 6, 2017 · 1 comment
Closed

EventFlow fails when contenerized app is debugged using Visual Studio Docker tools #139

karolz-ms opened this issue Oct 6, 2017 · 1 comment

Comments

@karolz-ms
Copy link
Collaborator

This is because CvsHealthReporter tries to create a log file on a read-only filesystem (tested with a container running in Linux mode)

We should figure out if there is an alternative location we could use for the reporter log.
This was referenced Nov 13, 2017
Closed
Merged
xiaomi7732 added a commit that referenced this issue Nov 16, 2017
@xiaomi7732
Address #138 & #139 (#150)
4fb15f8 
* Introduce the algorithm for rotating health report file

* Add configuration support for csv health report boundary

- SingleLogFileMaximumSizeInMBytes
- RententionLogsInDays

* Implement date window for csv health report

* Remove 'current' suffix for logs for compatbility

* Handle log folder no permission issue

* Add new tests for CsvHealthReporter

* Refactor rotate logfile to add testability

* Add testability to log retention

* Fix the .NET Core Console Consumer App

* Update README.md

* Get a better name of logRentensionInDays to replace RetensionLogsInDays

It is log retention than logs for retention.

* Rewords description for logRetentionInDays in README

* Revert the change to IRequireActivation

* Refactor the code for better testability

* Reword a code comment

* Bump up version number for EF.Core
@karolz-ms
Copy link
Collaborator Author

Fixed with Core nuget version 1.1.7 or newer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karolz-ms