Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

rename to Azure #20

Merged
merged 1 commit into from
May 8, 2017
Merged

rename to Azure #20

merged 1 commit into from
May 8, 2017

Conversation

bacongobbler
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented May 8, 2017

@bacongobbler,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@bacongobbler
Copy link
Contributor Author

Due to CI breakage, I'm running make bootstrap build locally to make sure everything works again before merging.

@bacongobbler
Copy link
Contributor Author

I'm able to run make bootstrap build and get a built version of draft with this PR now, so it's ready for review.

@ultimateboy
Copy link
Contributor

You sure about that? If you remove deis/draft from your $GOPATH, I doubt this still works. All the imports need updated too, right?!

@bacongobbler
Copy link
Contributor Author

I've moved from $GOPATH/src/github.com/deis/draft to $GOPATH/src/github.com/Azure/draft locally.

><> pwd
/Users/bacongobbler/go/src/github.com
><> ls deis/ | grep draft
><> ls Azure/ | grep draft
draft
><> cd Azure/draft/
><> git checkout rename-to-azure
Switched to branch 'rename-to-azure'
><> make build
GOBIN=/Users/bacongobbler/go/src/github.com/Azure/draft/bin go install  -tags 'kqueue' -ldflags ' -X github.com/Azure/draft/pkg/version.Version=v0.1.0 -X github.com/Azure/draft/pkg/version.GitCommit=f7755e099aa40f7ccd1858352ca0dc791e1e7285 -X github.com/Azure/draft/pkg/version.GitTreeState=clean' github.com/Azure/draft/cmd/...
><> ./bin/draft version
Client: &version.Version{SemVer:"canary", GitCommit:"f7755e099aa40f7ccd1858352ca0dc791e1e7285", GitTreeState:"clean"}
Error: cannot connect to draftd

@bacongobbler
Copy link
Contributor Author

All of the imports have been updated in this PR.

@bacongobbler
Copy link
Contributor Author

Sorry, that's wrong. They were updated in #18

@ultimateboy
Copy link
Contributor

OH! That's the PR I was missing. Thanks!

@bacongobbler bacongobbler merged commit 75c999c into Azure:master May 8, 2017
@bacongobbler bacongobbler deleted the rename-to-azure branch May 8, 2017 18:50
ultimateboy pushed a commit that referenced this pull request May 8, 2017
mboersma pushed a commit that referenced this pull request Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants