Support Add Task Activities from Abstract or Non-Sealed Class

[elokaac]

This change extends TaskHubWorker.AddTaskActivitiesFromInterface by supporting adding activities from abstract or non-sealed classes.

[cgillum]

I worry a little bit about this getting messy since methods on classes aren't always going to be properly designed to handle this kind of "remoting". It seems like an area where developers could run into various issues accidentally.

Would you be willing to consider a design where classes must opt certain methods into being used as interfaces, perhaps using an attribute? For example:

public abstract class ClassClient
{
    [TaskMethod]
    public abstract Task<T[]> Run<T>();
}

[elokaac]

I worry a little bit about this getting messy since methods on classes aren't always going to be properly designed to handle this kind of "remoting". It seems like an area where developers could run into various issues accidentally.

Would you be willing to consider a design where classes must opt certain methods into being used as interfaces, perhaps using an attribute? For example:

public abstract class ClassClient
{
    [TaskMethod]
    public abstract Task<T[]> Run<T>();
}

Having developers opt in methods when designing a class makes sense, though I feel like it makes things not so transparent for a user of the class who expects to be able to invoke all available methods.

[elokaac]

@cgillum , just curious, when you say "methods on classes aren't always going to be properly designed to handle this kind of remoting", what do you mean?

What differentiates class methods from interface methods in this context? Asides from the possibility of classes having private, protected or static methods?

[elokaac]

@cgillum , just curious, when you say "methods on classes aren't always going to be properly designed to handle this kind of remoting", what do you mean?

What differentiates class methods from interface methods in this context? Asides from the possibility of classes having private, protected or static methods?

@cgillum , just checking in on this if you don't mind sharing your thoughts.

[cgillum]

/azp run

[azure-pipelines]

EDIT: pipeline started successfully.

[cgillum]

LGTM!

[elokaac]

LGTM!

Thanks @cgillum. Can you help me merge it? Or how can I get access to be able to merge pull requests I create?