Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump send timeout to 30s #159

Merged
merged 1 commit into from
Sep 2, 2023
Merged

bump send timeout to 30s #159

merged 1 commit into from
Sep 2, 2023

Conversation

serbrech
Copy link
Member

@serbrech serbrech commented Sep 2, 2023 •
edited
Loading

Traces have shown send can succeed after up to 26s due to internal recovery code after idling.
defaulting to 30s to account for this.

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Pull Request Test Coverage Report for Build 6056381732

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 83.88%
Files with Coverage Reduction New Missed Lines %
v2/lockrenewer.go 3 94.74%
Totals Coverage Status
Change from base Build 5931135237: -0.4%
Covered Lines: 614
Relevant Lines: 732
💛 - Coveralls

@serbrech serbrech merged commit c1e0887 into main Sep 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenychen karenychen karenychen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serbrech @karenychen