Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Alignment] Support new Global Nav #15

Merged
merged 1 commit into from
Dec 8, 2018
Merged

[UI Alignment] Support new Global Nav #15

merged 1 commit into from
Dec 8, 2018

Conversation

vishwam
Copy link
Member

@vishwam vishwam commented Dec 7, 2018

  1. Add new colors to support the aligned sticky global nav.
  2. Deprecate the clickable mixin - the new UI does not require clickable behavior for buttons.

vincenzocaruso
vincenzocaruso reviewed Dec 7, 2018
View reviewed changes
src/_constants.scss Show resolved Hide resolved
src/light/_color.defaults.scss Show resolved Hide resolved
src/_constants.scss Show resolved Hide resolved
@vishwam vishwam merged commit a4dbd46 into master Dec 8, 2018
@vishwam vishwam deleted the vishwams_globalnav branch December 8, 2018 01:53
vishwam added a commit that referenced this pull request Jan 31, 2019
@vishwam
v6.0.0 - Align to new design language (#17)
c39fe26 
* [UI Alignment] Support new Global Nav (#15)

1. Add new colors to support the aligned sticky global nav.
2. Deprecate the clickable mixin - the new UI does not require clickable behavior for buttons.
3. Add new variables for context panel
4. Add new colors for masthead (#16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenzocaruso vincenzocaruso vincenzocaruso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishwam @vincenzocaruso