Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PR creation from release job. #2109

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

ouphi
Copy link
Collaborator

@ouphi ouphi commented Nov 1, 2023

What is being addressed

We are not allowed anymore to have PR creation done from Github action:

MicrosoftTeams-image (5)

Because of that the release job fails when trying to create the PR:

Screenshot 2023-11-01 at 10 18 40

How is this addressed

Change the release process:

  • The release job will be creating branches instead and the developer taking care of the release has to create the PRs.

@codecov-commenter
Copy link

Codecov Report

Merging #2109 (ecb1e9f) into dev (c32ecd8) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2109      +/-   ##
==========================================
- Coverage   83.00%   82.97%   -0.04%     
==========================================
  Files         256      256              
  Lines        9309     9309              
  Branches     1455     1455              
==========================================
- Hits         7727     7724       -3     
- Misses       1138     1140       +2     
- Partials      444      445       +1     

see 2 files with indirect coverage changes

@ouphi ouphi merged commit 4194561 into Azure:dev Nov 1, 2023
6 of 7 checks passed
@ouphi ouphi deleted the adapt-release-process branch November 1, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants