Add validation for null props inside objects inside arrays. #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (currentDepth > TwinPropertyMaxDepth) | ||
| { | ||
| throw new InvalidOperationException($"Nested depth of twin property exceeds {TwinPropertyMaxDepth}"); |
There was a problem hiding this comment.
Is this applicable to arrays as well? Have you confirmed with IoTHub behavior?
There was a problem hiding this comment.
If this is true for all json type fields then can we just move it out of the destructure ifs and put a single if depth check at the top of this fn?
There was a problem hiding this comment.
@nyanzebra, this is true for arrays and objects only. But you might have a point, so I moved that into a func to avoid duplications.
@varunpuranik, as discussed offline with the hub folks, I believe we need to keep nested arrays validaion.
varunpuranik
previously approved these changes
Apr 27, 2021
nyanzebra
reviewed
Apr 27, 2021
...core/test/Microsoft.Azure.Devices.Edge.Hub.Core.Test/twin/ReportedPropertiesValidatorTest.cs
Outdated
Show resolved
Hide resolved
nyanzebra
approved these changes
May 3, 2021
varunpuranik
approved these changes
May 4, 2021
vadim-kovalyov
added a commit
to vadim-kovalyov/iotedge
that referenced
this pull request
May 4, 2021
Add validation for null props inside objects inside arrays.
kodiakhq bot
pushed a commit
that referenced
this pull request
May 5, 2021
…4941) Add validation for null props inside objects inside arrays. Since IoT Hub does not support patch operations on arrays (if you want to update array, you need to replace it), they don't allow null values or null properties inside arrays. EdgeHub, on the other hand, allows that. So, validation can pass on the EdgeHub side, but the update will be rejected by the hub. This situation allows for sending bad payloads, that blocks any further twin updates unless bad property is removed/cleared.
yophilav
added a commit
to yophilav/iotedge
that referenced
this pull request
May 12, 2021
Update test rusting rusting Style Style C# parsing Parsing with test Add validation for null props inside objects inside arrays. (Azure#4896) (Azure#4941) Add validation for null props inside objects inside arrays. Since IoT Hub does not support patch operations on arrays (if you want to update array, you need to replace it), they don't allow null values or null properties inside arrays. EdgeHub, on the other hand, allows that. So, validation can pass on the EdgeHub side, but the update will be rejected by the hub. This situation allows for sending bad payloads, that blocks any further twin updates unless bad property is removed/cleared.
yophilav
pushed a commit
to yophilav/iotedge
that referenced
this pull request
May 13, 2021
…) (Azure#4941) Add validation for null props inside objects inside arrays. Since IoT Hub does not support patch operations on arrays (if you want to update array, you need to replace it), they don't allow null values or null properties inside arrays. EdgeHub, on the other hand, allows that. So, validation can pass on the EdgeHub side, but the update will be rejected by the hub. This situation allows for sending bad payloads, that blocks any further twin updates unless bad property is removed/cleared.
vipeller
pushed a commit
to vipeller/iotedge
that referenced
this pull request
May 26, 2021
kodiakhq bot
pushed a commit
that referenced
this pull request
May 26, 2021
#5034) …#4941) Since IoT Hub does not support patch operations on arrays (if you want to update array, you need to replace it), they don't allow null values or null properties inside arrays. EdgeHub, on the other hand, allows that. So, validation can pass on the EdgeHub side, but the update will be rejected by the hub. This situation allows for sending bad payloads, that blocks any further twin updates unless bad property is removed/cleared.
ggjjj
pushed a commit
to ggjjj/iotedge
that referenced
this pull request
Jul 22, 2021
Add validation for null props inside objects inside arrays.
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
Add validation for null props inside objects inside arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation for null props inside objects inside arrays.
Since IoT Hub does not support patch operations on arrays (if you want to update array, you need to replace it), they don't allow null values or null properties inside arrays. EdgeHub, on the other hand, allows that. So, validation can pass on the EdgeHub side, but the update will be rejected by the hub. This situation allows for sending bad payloads, that blocks any further twin updates unless bad property is removed/cleared.