Enable ARM32 E2E Test After Mitigating Docker Network Issue #5561
Conversation
nimanch
changed the title
| @@ -108,11 +108,13 @@ public string[] GetInstallCommandsFromLocal(string path) | |||
| { | |||
| SupportedPackageExtension.Deb => new[] | |||
| { | |||
| "apt-get purge --yes aziot-edge aziot-identity-service libiothsm-std iotedge" | |||
| "apt-get purge --yes aziot-edge aziot-identity-service libiothsm-std iotedge", | |||
There was a problem hiding this comment.
Since this is a release/1.1 branch. The removal of aziot-* are not necessary -- it doesn't hurt to have them as a precaution. If you want to keep the aziot removal here, please use aziot-* instead of specifying the name 2/4 of the existing aziot components.
There was a problem hiding this comment.
I dont think I have made any changes to that line of code , the only change was to add the restart docker command. Would you want me to make this change in this PR or create a separate PBI to update this?
There was a problem hiding this comment.
Would you want me to make this change in this PR or create a separate PBI to update this?
Yes please.
There was a problem hiding this comment.
| @@ -42,6 +43,17 @@ public async Task BeforeAllAsync() | |||
|
|
|||
| // Install IoT Edge, and do some basic configuration | |||
| await this.daemon.UninstallAsync(token); | |||
|
|
|||
| // Delete directories used by previous installs. | |||
| List<string> directories = new List<string>() { "/run/iotedge", "/var/lib/iotedge", "/var/run/iotedge" }; | |||
There was a problem hiding this comment.
These paths are only true for release/1.1 branch. If you want to be inclusive to 1.2, the var/lib/aziot/*, /var/run/aziot/*, /etc/aziot are needed to be removed as well.
There was a problem hiding this comment.
I believe that is handled is 1.2 and master branches and the intention is to keep this change isolated to only 1.1 branch and not merge it back to master
All Failures in ARM32 were occuring due to failure of a Module to be installed due to the container being previously attached to the aziot docker network. This is a known bug in docker docker/cli#1891.
The problem is mitigated by restarting docker service on uninstall of edge daemon during teardown sequence.