Default to release/1.1 branch for conn test pipeline resources #5566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on enabling scheduled runs of the connectivity test pipeline on release/1.1? They're currently only scheduled for release/1.2 and master. |
damonbarry
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
I assume we want scheduled triggers, but @and-rewsmith or @yophilav can confirm. And that can be added separately. At least this should ensure that manual builds pick the right branch by default.
| @@ -9,10 +9,10 @@ resources: | |||
| pipelines: | |||
| - pipeline: images | |||
| source: 'Azure-IoT-Edge-Core Build Images' | |||
| branch: 'master' | |||
| branch: 'release/1.1' | |||
There was a problem hiding this comment.
You may want to point out in the PR description that this is for manual builds only (and scheduled, but as you pointed out, scheduled triggers aren't set up in this branch).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually triggered connectivity test pipeline runs on release/1.1 are defaulting to artifacts from the master branch for Build Images and Edgelet Packages. This is a mistake and they should be using artifacts from release/1.1 by default.