Fix edgehub_queue_len counting #5730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the count of eh_queue_len by using only the metrics as counters and not setting through other means. We will only increment on propose and decrement on commit. We initialize the count based on how many entries are in the queue from the checkpoint's offset. We still update the count whenever we cleanup the queue. NOTE Below graph is with TTL of 7200 seconds and the change in color is when edgeHub was restarted.
varunpuranik
approved these changes
Oct 25, 2021
|
Just to show correct behavior on TTL
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #5692
NOTE
Below are graphs with TTL 300; first is online burst and second is offline.. for some reason these look different than what I saw for #5731 (1.2) and guess the reason is due to message processing rates somehow being different... tested on a rpi so maybe resources were used more in one vs the other?