Implement the new monitor-events CLI for Py35+ users #236
Conversation
Add quickstart video
* add contributing.md and modify readme to point to wiki * update readme.md * remove overview section and move resources to bottom * add overview section with link to wiki at top
| @@ -35,6 +35,7 @@ def run(self): | |||
| 'python-dotenv', | |||
| 'requests', | |||
| 'fstrings', | |||
| 'msrestazure~=0.4.32', | |||
There was a problem hiding this comment.
This is needed for py2 due to an issue with Azure/azure-cli#6973
| @@ -304,7 +304,7 @@ def stop_simulator(): | |||
| help="Specify number of milliseconds to monitor for messages") | |||
| def monitor(timeout): | |||
| utility = Utility(envvars, output) | |||
| ih = IoTHub(envvars, utility, output) | |||
| ih = IoTHub(envvars, utility, output, azure_cli) | |||
| ih.monitor_events(timeout) | |||
There was a problem hiding this comment.
What's the unit of timeout? Is it still milliseconds? The behavior seems to be inconsistent with Python 2 and Python 3.6. With Python 3.6, I have specified 10 as timeout, but the monitor session ran several minutes.
There was a problem hiding this comment.
Both should be seconds:
https://github.com/Azure/iothub-explorer/blob/master/iothub-explorer-monitor-events.js#L45
@digimaun - Is this correct?
There was a problem hiding this comment.
I think I found out the cause of the inconsistency. The timeout option for iothub-explorer monitor-events specifies "Exit after the given number of seconds". In comparison, the timeout option for az iot hub monitor-events specifies "Maximum seconds to maintain connection without receiving message". Since my Edge device is continuously sending messages to IoT Hub, when monitoring on Python 3.6, the monitor session will never stop.
There was a problem hiding this comment.
Yes the extension timeout is in seconds and @LazarusX's comment is right on the timeout behavior for monitor-events
There was a problem hiding this comment.
@digimaun - I'm trying to add a timeout to process.communicate to force kill the monitor-events process. Can you review this commit and LMK why you think it is not actually killing the process. Also, can you recommend other ways to get this behavior? Thanks!
There was a problem hiding this comment.
I sent a PR to your personal repo on the same processtimeout branch. Also please read note about sys.excepthook errors.
There was a problem hiding this comment.
It didn’t fully work yet. paymaun will have a look this week to figure out why tod is failing. Please feel free to try if you have time. You can pull fork
No description provided.