docs: update workspace install namespace #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Welz <philip.welz@googlemail.com>
philwelz
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
Signed-off-by: Philip Welz <philip.welz@googlemail.com>
ishaansehgal99
requested changes
Apr 3, 2024
|
@ishaansehgal99 sure here you go : #336 |
|
The issue has been fixed via #337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
If you install the the workspace controller to the
kaito-workspacenamespace as described in the docs, you get the following error when installing the workspace model (falcon-7b-instruct for example):Error from server (InternalError): error when creating "./kaito/falcon.yaml": Internal error occurred: failed calling webhook "validation.workspace.kaito.sh": failed to call webhook: Post "https://workspace.workspace.svc:9443/?timeout=10s": service "workspace" not foundSo this PR fixes the namespace for the workspace controller.