fix: Update namespace in the helm chart #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>
Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>
helayoty
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
- Coverage 63.87% 62.89% -0.99%
==========================================
Files 14 14
Lines 1301 1307 +6
==========================================
- Hits 831 822 -9
- Misses 432 447 +15
Partials 38 38 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com>
|
The fixed issue should be #336. |
ishaansehgal99
temporarily deployed
to
unit-tests
GitHub Actions
Inactive
ishaansehgal99
had a problem deploying
to
e2e-test
GitHub Actions
Failure
ishaansehgal99
approved these changes
Apr 3, 2024
helayoty
added a commit
that referenced
this pull request
Apr 4, 2024
**Reason for Change**: - Update the namespace to use the release namespace. **Requirements** - [ ] added unit tests and e2e tests (if applicable). **Issue Fixed**: Fixes #336 **Notes for Reviewers**: --------- Signed-off-by: Heba <31887807+helayoty@users.noreply.github.com> Co-authored-by: ishaansehgal99 <ishaanforthewin@gmail.com>
This was referenced Apr 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Requirements
Issue Fixed:
Fixes #336
Notes for Reviewers: