fix: long running setup for expired auth token track 2 bug #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bryce-Soghigian
added
the
kind/experiment
Pull Request Test Coverage Report for Build 9421738010Details
💛 - Coveralls |
andyzhangx
reviewed
Jun 10, 2024
pkg/auth/cred.go
Outdated
| return azcore.AccessToken{}, err | ||
| } | ||
| logging.FromContext(ctx).Info("refreshing MDAL Token") | ||
| token.ExpiresOn = time.Now().Add(1 * time.Hour) |
There was a problem hiding this comment.
I think 2 hours is better since the original expiration time is 2 hours
Pull Request Test Coverage Report for Build 9450969455Details
💛 - Coveralls |
Bryce-Soghigian
force-pushed
the
bsoghigian/token/repro
branch
from
2e7c340
to
bde0ca5
Compare
Pull Request Test Coverage Report for Build 9522232903Details
💛 - Coveralls |
Bryce-Soghigian
changed the title
Pull Request Test Coverage Report for Build 9590583019Details
💛 - Coveralls |
|
does this workaround work? @Bryce-Soghigian |
zarvd
reviewed
Jun 21, 2024
pkg/auth/cred.go
Outdated
| return azcore.AccessToken{}, err | ||
| } | ||
| logging.FromContext(ctx).Info("refreshing MDAL Token") | ||
| token.ExpiresOn = time.Now().Add(2 * time.Hour) |
There was a problem hiding this comment.
Do we need to check the original ExpiresOn in case it’s already less than 2 hours?
There was a problem hiding this comment.
I think that would be prudent
There was a problem hiding this comment.
IIRC the underlying token credential attempts to fetch from the cache first. It seems like it could return a short-lived token?
There was a problem hiding this comment.
yep this value should be set with the minimum value of token expires on and the 2hr we want to use here.
|
@andyzhangx yes it seems to be working for over a week for me |
Bryce-Soghigian
added
kind/bug
comtalyst
reviewed
Jun 21, 2024
tallaxes
reviewed
Jun 22, 2024
bcho
reviewed
Jun 24, 2024
Pull Request Test Coverage Report for Build 9669960661Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
bcho
reviewed
Jun 25, 2024
Bryce-Soghigian
commented
Jun 25, 2024
Pull Request Test Coverage Report for Build 9670992016Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9700805392Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
bcho
reviewed
Jun 27, 2024
Pull Request Test Coverage Report for Build 9701170413Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
tallaxes
approved these changes
Jun 27, 2024
Pull Request Test Coverage Report for Build 9718106940Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
The track 2 sdk has a bug for long living tokens(longer than 24hrs) they will not be refreshed properly. This pr adds a thin wrapper around the GetToken() interface method to set the ExpiresOn timestamp to be earlier and force a token refresh earlier.
How was this change tested?
Does this change impact docs?
Release Note