Add tool mode and tcpdump tool #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return fmt.Sprintf(" and %s", s) | ||
| } | ||
|
|
||
| func ParseIPAndPort(s string) (ip string, port string) { |
There was a problem hiding this comment.
Does the net.SplitHostPort work for you?
There was a problem hiding this comment.
I tried. That makes ipv6 available, but you have to add more parameters to assign port respectively. I'd prefer to make the parameter easy here.
There was a problem hiding this comment.
OK. Good enough for now. We can figure it out later how to make IPv6 work (we're going to need this soon :)
added 3 commits
May 27, 2022 14:58
ArchangelSDY
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15 #14