Fix merge conflicts and breaking changes in PR 221 #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/Azure/azure-sdk-for-go/sdk/azidentity](https://github.com/Azure/azure-sdk-for-go) from 1.1.0 to 1.2.2. - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/sdk/azidentity/v1.2.2/CHANGELOG.md) - [Commits](Azure/azure-sdk-for-go@v1.1...sdk/azidentity/v1.2.2) --- updated-dependencies: - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azidentity dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…/sdk/azidentity-1.2.2' of https://github.com/Azure/kubelogin into fix-pr-221
confidential.WithAuthority has been deleted in breaking change. Making the recommended code changes to pass the authority url as a param.
Created inline callback function that reads token from file Updated test that is outdated with the change
Moved file read out of callback. Added smaller functions so I could test edge cases. Need to add more UTs and comments for new functions.
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 50.13% 50.18% +0.04%
==========================================
Files 15 15
Lines 1105 1100 -5
==========================================
- Hits 554 552 -2
+ Misses 520 517 -3
Partials 31 31
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually merging and updating code to accomodate breaking changes introduced in #221
Created UTs for new helper functions
Updated .gitignore for JetBrains tools
How Tested:
Ran UTs
make testRan quickstart guide on an AKS Cluster