Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKS 1.24.0: kubeconfig to azurecli #94

Merged
merged 8 commits into from
Jul 7, 2022
Merged

AKS 1.24.0: kubeconfig to azurecli #94

merged 8 commits into from
Jul 7, 2022

Conversation

anmathew
Copy link
Contributor

@anmathew anmathew commented Jul 6, 2022

Addresses #93

@ghost
Copy link

ghost commented Jul 6, 2022 •
edited by ghost

CLA assistant check
All CLA requirements met.

weinong
weinong reviewed Jul 6, 2022
View reviewed changes
pkg/converter/convert.go Outdated Show resolved Hide resolved
weinong
weinong reviewed Jul 6, 2022
View reviewed changes
pkg/converter/convert.go Outdated Show resolved Hide resolved
weinong
weinong reviewed Jul 7, 2022
View reviewed changes
pkg/converter/convert.go Outdated Show resolved Hide resolved
weinong
weinong reviewed Jul 7, 2022
View reviewed changes
pkg/converter/convert.go Outdated Show resolved Hide resolved
weinong
weinong reviewed Jul 7, 2022
View reviewed changes
pkg/converter/convert.go Outdated Show resolved Hide resolved
weinong
weinong reviewed Jul 7, 2022
View reviewed changes
pkg/converter/convert.go Outdated Show resolved Hide resolved
weinong
weinong reviewed Jul 7, 2022
View reviewed changes
pkg/converter/convert.go Outdated Show resolved Hide resolved
weinong
weinong reviewed Jul 7, 2022
View reviewed changes
pkg/converter/convert.go Outdated Show resolved Hide resolved
weinong
weinong reviewed Jul 7, 2022
View reviewed changes
pkg/converter/convert.go Outdated Show resolved Hide resolved
weinong
weinong approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@weinong weinong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinong weinong merged commit f345047 into Azure:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weinong weinong weinong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anmathew @weinong @evuraan