Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a workflow for apply and destroy terraform #83

Merged
merged 14 commits into from
Mar 18, 2021

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented Mar 16, 2021

Description

  • updates build/apply_tf.sh and build/destroy_tf.sh to attempt to apply and destroy Terraform multiple times before giving up (whether that's due to transient errors or real ones).
  • adds apply_and_destroy_terraform.yml to pull known configuration from a storage account, login using known credentials, and attempt to execute build/apply_tf.sh and build/destroy_tf.sh from a GitHub Actions workflow

Issue reference

The issue this PR will close: #48, #88

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa changed the title [do not merge] add a workflow for apply and destroy terraform [do not merge, waiting on #61, #80, and #82] add a workflow for apply and destroy terraform Mar 16, 2021
@glennmusa glennmusa linked an issue Mar 17, 2021 that may be closed by this pull request
@glennmusa glennmusa changed the title [do not merge, waiting on #61, #80, and #82] add a workflow for apply and destroy terraform [do not merge, waiting #82] add a workflow for apply and destroy terraform Mar 17, 2021
@glennmusa glennmusa changed the title [do not merge, waiting #82] add a workflow for apply and destroy terraform add a workflow for apply and destroy terraform Mar 18, 2021
@glennmusa
Copy link
Contributor Author

I wanted to run this on a schedule, but I don't have the magic touch to trigger a cron event since it doesn't appear GitHub Actions are reliable on a schedule:

https://github.community/t/no-assurance-on-scheduled-jobs/133753/2

This is ready for merging.

@glennmusa glennmusa changed the title add a workflow for apply and destroy terraform [do not merge (yet)] add a workflow for apply and destroy terraform Mar 18, 2021
@glennmusa glennmusa changed the title [do not merge (yet)] add a workflow for apply and destroy terraform add a workflow for apply and destroy terraform Mar 18, 2021
@glennmusa glennmusa merged commit 0b394c0 into main Mar 18, 2021
@glennmusa glennmusa deleted the glennmusa/terraformworkflow branch March 18, 2021 19:27
Breanna-Stryker added a commit that referenced this pull request Mar 19, 2021
* add the shellcheck extension to the devcontainer (#70)

Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com>

* Enable Azure Security Center in MLZ subscriptions (#55)

* Updated documentation in script

* - Added execution flag to shell scripts
- Added configure_asc.sh script
- Added code to create subs array to mlz_tf_setup.sh
- Added code to call configure_asc.sh from mlz_tf_setup.sh

* - Added executable flag to unzipprovider.sh script

* - Added executable flag to check scripts

* - Updated loop code for workspace setting

* - Created folder for ASC scripts
- Copied generate_names.sh script into ASC folder

* - Removed ASC calling code from setup script
- Updated naming in asc script
- Added ASC naming to generate script

* - Moved LAWS name generation into generate names
- Moved generate names call into loop
- Updated wait loop to use variables

* - Removed message for elapsed time
- Added quotes consistently for echo's

* - Updated Copyright statement
- Added set -e
- Modified variables to use env & location from vars file

* - Corrected counter logic
- Corrected description in names script

* output number of attempts remaining

* add a comment that this may fail

* - Removed creater comment

* unusually typo

Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com>

* Add persona and business justification to the Issue template (#73)

* issue template update

* Implement error handling into shell scripts (#72)

* - Added error handling to configure_asc script
- Suppressed "create" output in configure_asc script

* - Added error handling to config_create script
- Remove commented lines from configure_asc script

* - Added error handling to config_validate script

* - Added error handling to get_sp_identity script
- Corrected SP lookup

* - Added error handling to mlz_config_create script

* - Updated echo lines

* Implement Sub ID array for Role assignment (#76)

* - Updated bullet numbering in README
- Added code to create sub id array

* - Reverted numbering changes made to README.md

* - Added description of sed command

* - Added parameter to suppress WARNING on sp create

* Remove providers (#84)

* use azurerm 2.50 in src/core

* removing provider files

* updates to readme and scripts for local providers

* set tf provider folder

Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com>

* unique diagnostic settings names (#82)

Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com>

* move scripts to src/scripts (#87)

* add a workflow for apply and destroy terraform (#83)

* add retries for apply and destroy

* update readmes

Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com>
Co-authored-by: Byron Boudreaux <16844071+Phydeauxman@users.noreply.github.com>
Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Co-authored-by: Breanna-Stryker <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants