Enable Azure Security Center in MLZ subscriptions #55

Phydeauxman · 2021-03-02T23:20:19Z

Description

Code enables Azure Security Center with configurations below on each sub used for the MLZ deployment:

Sets VirtualMachines to Standard
Sets StorageAccounts to Standard
Creates Log Analytics workspace
Configures ASC to use the workspace as the default
Enables auto-provisioning

Issue reference

The issue this PR will close: #7

- Added configure_asc.sh script - Added code to create subs array to mlz_tf_setup.sh - Added code to call configure_asc.sh from mlz_tf_setup.sh

glennmusa · 2021-03-03T14:32:59Z

The Pull Request could use a better title, it's what makes it into the history (see below for examples). Looks like this is "add ability to enable Azure Security Center"?

scripts/configure_asc.sh

glennmusa · 2021-03-03T15:00:02Z

scripts/configure_asc.sh

@@ -0,0 +1,126 @@
+#!/bin/bash


I think this deserves it's own folder to house all the things it's doing:

└──src └──scripts └──security-center └──generate_asc_names.sh └──configure_asc.sh └──remove_asc.sh # eventually creating this script └──config

scripts/configure_asc.sh

src/provider_archive/unzipprovider.sh

scripts/mlz_tf_setup.sh

scripts/configure_asc.sh

scripts/mlz_tf_setup.sh

brooke-hamilton

This PR has conflicts in two files. Are you planning to replace the existing files with your changes, i.e. should I review them as-is, or should I wait for you to fix the conflicts?
scripts/mlz_config_validate.sh
scripts/mlz_tf_setup.sh

- Copied generate_names.sh script into ASC folder

- Updated naming in asc script - Added ASC naming to generate script

- Moved generate names call into loop - Updated wait loop to use variables

scripts/security-center/configure_asc.sh

- Added quotes consistently for echo's

scripts/security-center/configure_asc.sh

scripts/security-center/generate_names.sh

scripts/security-center/configure_asc.sh

- Added set -e - Modified variables to use env & location from vars file

- Corrected description in names script

…re/asc

* add the shellcheck extension to the devcontainer (#70) Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * Enable Azure Security Center in MLZ subscriptions (#55) * Updated documentation in script * - Added execution flag to shell scripts - Added configure_asc.sh script - Added code to create subs array to mlz_tf_setup.sh - Added code to call configure_asc.sh from mlz_tf_setup.sh * - Added executable flag to unzipprovider.sh script * - Added executable flag to check scripts * - Updated loop code for workspace setting * - Created folder for ASC scripts - Copied generate_names.sh script into ASC folder * - Removed ASC calling code from setup script - Updated naming in asc script - Added ASC naming to generate script * - Moved LAWS name generation into generate names - Moved generate names call into loop - Updated wait loop to use variables * - Removed message for elapsed time - Added quotes consistently for echo's * - Updated Copyright statement - Added set -e - Modified variables to use env & location from vars file * - Corrected counter logic - Corrected description in names script * output number of attempts remaining * add a comment that this may fail * - Removed creater comment * unusually typo Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com> Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> Co-authored-by: Byron Boudreaux <16844071+Phydeauxman@users.noreply.github.com>

* add the shellcheck extension to the devcontainer (#70) Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * Enable Azure Security Center in MLZ subscriptions (#55) * Updated documentation in script * - Added execution flag to shell scripts - Added configure_asc.sh script - Added code to create subs array to mlz_tf_setup.sh - Added code to call configure_asc.sh from mlz_tf_setup.sh * - Added executable flag to unzipprovider.sh script * - Added executable flag to check scripts * - Updated loop code for workspace setting * - Created folder for ASC scripts - Copied generate_names.sh script into ASC folder * - Removed ASC calling code from setup script - Updated naming in asc script - Added ASC naming to generate script * - Moved LAWS name generation into generate names - Moved generate names call into loop - Updated wait loop to use variables * - Removed message for elapsed time - Added quotes consistently for echo's * - Updated Copyright statement - Added set -e - Modified variables to use env & location from vars file * - Corrected counter logic - Corrected description in names script * output number of attempts remaining * add a comment that this may fail * - Removed creater comment * unusually typo Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * Add persona and business justification to the Issue template (#73) * issue template update * Implement error handling into shell scripts (#72) * - Added error handling to configure_asc script - Suppressed "create" output in configure_asc script * - Added error handling to config_create script - Remove commented lines from configure_asc script * - Added error handling to config_validate script * - Added error handling to get_sp_identity script - Corrected SP lookup * - Added error handling to mlz_config_create script * - Updated echo lines * Implement Sub ID array for Role assignment (#76) * - Updated bullet numbering in README - Added code to create sub id array * - Reverted numbering changes made to README.md * - Added description of sed command * - Added parameter to suppress WARNING on sp create * Remove providers (#84) * use azurerm 2.50 in src/core * removing provider files * updates to readme and scripts for local providers * set tf provider folder Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * unique diagnostic settings names (#82) Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> * move scripts to src/scripts (#87) * add a workflow for apply and destroy terraform (#83) * add retries for apply and destroy * update readmes Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com> Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com> Co-authored-by: Byron Boudreaux <16844071+Phydeauxman@users.noreply.github.com> Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Co-authored-by: Breanna-Stryker <>

* Updated documentation in script * - Added execution flag to shell scripts - Added configure_asc.sh script - Added code to create subs array to mlz_tf_setup.sh - Added code to call configure_asc.sh from mlz_tf_setup.sh * - Added executable flag to unzipprovider.sh script * - Added executable flag to check scripts * - Updated loop code for workspace setting * - Created folder for ASC scripts - Copied generate_names.sh script into ASC folder * - Removed ASC calling code from setup script - Updated naming in asc script - Added ASC naming to generate script * - Moved LAWS name generation into generate names - Moved generate names call into loop - Updated wait loop to use variables * - Removed message for elapsed time - Added quotes consistently for echo's * - Updated Copyright statement - Added set -e - Modified variables to use env & location from vars file * - Corrected counter logic - Corrected description in names script * output number of attempts remaining * add a comment that this may fail * - Removed creater comment * unusually typo Co-authored-by: Glenn Musa <glennmusa@users.noreply.github.com>

Phydeauxman and others added 5 commits February 27, 2021 14:54

Updated documentation in script

86c5391

- Added execution flag to shell scripts

5171e0c

- Added configure_asc.sh script - Added code to create subs array to mlz_tf_setup.sh - Added code to call configure_asc.sh from mlz_tf_setup.sh

- Added executable flag to unzipprovider.sh script

e1b3191

- Added executable flag to check scripts

d844b8b

- Updated loop code for workspace setting

1655d55

glennmusa reviewed Mar 3, 2021

View reviewed changes

scripts/mlz_tf_setup.sh Outdated Show resolved Hide resolved

glennmusa reviewed Mar 3, 2021

View reviewed changes

scripts/configure_asc.sh Outdated Show resolved Hide resolved

glennmusa reviewed Mar 3, 2021

View reviewed changes

scripts/mlz_tf_setup.sh Outdated Show resolved Hide resolved

brooke-hamilton reviewed Mar 3, 2021

View reviewed changes

Phydeauxman changed the title ~~Byboudre/asc~~ Enable Azure Security Center in MLZ subscriptions Mar 3, 2021

Phydeauxman and others added 5 commits March 3, 2021 19:58

Merge branch 'main' into byboudre/asc

810e330

- Created folder for ASC scripts

589a00c

- Copied generate_names.sh script into ASC folder

Merge branch 'main' into byboudre/asc

636edf4

- Removed ASC calling code from setup script

a2eb239

- Updated naming in asc script - Added ASC naming to generate script

- Moved LAWS name generation into generate names

655dc6f

- Moved generate names call into loop - Updated wait loop to use variables

Phydeauxman requested a review from Breanna-Stryker March 5, 2021 23:34

glennmusa suggested changes Mar 8, 2021

View reviewed changes

scripts/security-center/configure_asc.sh Outdated Show resolved Hide resolved

scripts/security-center/configure_asc.sh Outdated Show resolved Hide resolved

scripts/security-center/configure_asc.sh Outdated Show resolved Hide resolved

Phydeauxman added 2 commits March 8, 2021 19:19

- Removed message for elapsed time

7c08f39

- Added quotes consistently for echo's

Merge branch 'main' into byboudre/asc

4ee580f

glennmusa suggested changes Mar 8, 2021

View reviewed changes

scripts/security-center/configure_asc.sh Outdated Show resolved Hide resolved

scripts/security-center/generate_names.sh Outdated Show resolved Hide resolved

glennmusa reviewed Mar 8, 2021

View reviewed changes

scripts/security-center/configure_asc.sh Outdated Show resolved Hide resolved

glennmusa reviewed Mar 8, 2021

View reviewed changes

scripts/security-center/configure_asc.sh Outdated Show resolved Hide resolved

Phydeauxman and others added 6 commits March 8, 2021 23:19

- Updated Copyright statement

761e455

- Added set -e - Modified variables to use env & location from vars file

- Corrected counter logic

f74f8de

- Corrected description in names script

Merge branch 'main' into byboudre/asc

5811e22

output number of attempts remaining

50e8419

add a comment that this may fail

8115f03

- Removed creater comment

2d3aa4f

glennmusa added 2 commits March 9, 2021 14:13

unusually typo

7ee8831

Merge branch 'byboudre/asc' of github.com:Azure/missionlz into byboud…

f28f0a1

…re/asc

glennmusa approved these changes Mar 9, 2021

View reviewed changes

Phydeauxman merged commit 031d896 into main Mar 9, 2021

Phydeauxman deleted the byboudre/asc branch March 9, 2021 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Azure Security Center in MLZ subscriptions #55

Enable Azure Security Center in MLZ subscriptions #55

Phydeauxman commented Mar 2, 2021

glennmusa commented Mar 3, 2021 •

edited

Loading

glennmusa Mar 3, 2021

brooke-hamilton left a comment

Enable Azure Security Center in MLZ subscriptions #55

Enable Azure Security Center in MLZ subscriptions #55

Conversation

Phydeauxman commented Mar 2, 2021

Description

Issue reference

glennmusa commented Mar 3, 2021 • edited Loading

glennmusa Mar 3, 2021

Choose a reason for hiding this comment

brooke-hamilton left a comment

Choose a reason for hiding this comment

glennmusa commented Mar 3, 2021 •

edited

Loading