-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Recommendation Package #380
Conversation
|
||
val filtered = helper.filterRatings(transformedDf) | ||
filtered.cache().count() | ||
// transformedDf.unpersist() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: remove commented out code, I see it in a lot of places
assert(map("precisionAtk") == 0.5) | ||
} | ||
|
||
// override def serializationTestObjects(): Seq[TestObject[RecommendationEvaluator]] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
@@ -0,0 +1 @@ | |||
Recommender Software. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add a summary here in the style of other modules. This is what is shown in the python/R docs for the module.
override lazy val sc: SparkContext = session.sparkContext | ||
|
||
private[spark] lazy val df = { | ||
session.createDataFrame(Seq( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nicer if these were put in 3 separate files. I think we can do that in a separate PR after this.
Pass! — The build has succeeded. (56206725) MMLSpark 0.14.dev0+10.g56206725This is a build for Github PR #380, changes:
|
@dciborow sorry if you are running into a bing image search test failure, i fixed that issue and am in the process of merging it in! Update: Its fixed! |
Pass! — The build has succeeded. (56206725) MMLSpark 0.14.dev0+10.g56206725This is a build for Github PR #380, changes:
|
Pass! — The build has succeeded. (d230f189) MMLSpark 0.14.dev0+11.gd230f189This is a build for Github PR #380, changes:
|
Pass! — The build has succeeded. (324fe44b) MMLSpark 0.14.dev0+12.g324fe44bThis is a build for Github PR #380, changes:
|
# Conflicts: # src/recommendation/src/main/python/TrainValidRecommendSplit.py
Pass! — The build has succeeded. (e85baafc) MMLSpark 0.14.dev6+58.ge85baafcThis is a build for Github PR #380, changes:
|
Pass! — The build has succeeded. (e85baafc) MMLSpark 0.14.dev6+58.ge85baafcThis is a build for Github PR #380, changes:
|
Pass! — The build has succeeded. (5d29aa99) MMLSpark 0.14.dev6+59.g5d29aa99This is a build for Github PR #380, changes:
|
Pass! — The build has succeeded. (af93d1d7) MMLSpark 0.14.dev6+60.gaf93d1d7This is a build for Github PR #380, changes:
|
No description provided.