Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Recommendation Package #380

Closed
wants to merge 60 commits into from
Closed

Conversation

dciborow
Copy link
Contributor

No description provided.


val filtered = helper.filterRatings(transformedDf)
filtered.cache().count()
// transformedDf.unpersist()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: remove commented out code, I see it in a lot of places

assert(map("precisionAtk") == 0.5)
}

// override def serializationTestObjects(): Seq[TestObject[RecommendationEvaluator]] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@@ -0,0 +1 @@
Recommender Software.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add a summary here in the style of other modules. This is what is shown in the python/R docs for the module.

override lazy val sc: SparkContext = session.sparkContext

private[spark] lazy val df = {
session.createDataFrame(Seq(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nicer if these were put in 3 separate files. I think we can do that in a separate PR after this.

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (56206725)

MMLSpark 0.14.dev0+10.g56206725

This is a build for Github PR #380, changes:


@mmlspark-bot
Copy link
Contributor

@mhamilton723
Copy link
Collaborator

mhamilton723 commented Oct 4, 2018

@dciborow sorry if you are running into a bing image search test failure, i fixed that issue and am in the process of merging it in!

Update: Its fixed!

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (56206725)

MMLSpark 0.14.dev0+10.g56206725

This is a build for Github PR #380, changes:


@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (d230f189)

MMLSpark 0.14.dev0+11.gd230f189

This is a build for Github PR #380, changes:


@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (324fe44b)

MMLSpark 0.14.dev0+12.g324fe44b

This is a build for Github PR #380, changes:


@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (e85baafc)

MMLSpark 0.14.dev6+58.ge85baafc

This is a build for Github PR #380, changes:


@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (e85baafc)

MMLSpark 0.14.dev6+58.ge85baafc

This is a build for Github PR #380, changes:


@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (5d29aa99)

MMLSpark 0.14.dev6+59.g5d29aa99

This is a build for Github PR #380, changes:


@mmlspark-bot
Copy link
Contributor

PASS Pass! — The build has succeeded. (af93d1d7)

MMLSpark 0.14.dev6+60.gaf93d1d7

This is a build for Github PR #380, changes:


@dciborow dciborow closed this Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants