Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranking evaluator and adapater #415

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

dciborow
Copy link
Contributor

No description provided.

@mmlspark-bot

This comment has been minimized.

@mmlspark-bot
Copy link
Contributor

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some first comments with first pass-through

src/recommendation/src/main/scala/RankingAdapter.scala Outdated Show resolved Hide resolved
src/recommendation/src/main/scala/RankingAdapter.scala Outdated Show resolved Hide resolved
src/recommendation/src/main/scala/RankingAdapter.scala Outdated Show resolved Hide resolved
src/recommendation/src/main/scala/RankingEvaluator.scala Outdated Show resolved Hide resolved
src/recommendation/src/main/scala/RankingEvaluator.scala Outdated Show resolved Hide resolved
@mmlspark-bot
Copy link
Contributor

@mmlspark-bot
Copy link
Contributor

@mmlspark-bot

This comment has been minimized.

@mmlspark-bot

This comment has been minimized.

Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me just a few minors Qs

@dciborow dciborow changed the title Ranking adapater Ranking evaluator and adapater Oct 31, 2018
@mmlspark-bot

This comment has been minimized.

@mmlspark-bot

This comment has been minimized.

@mmlspark-bot
Copy link
Contributor

[A build has started. (3fa5939)](https://msazure.visualstudio.com/Cognitive Services/_build/index?buildId=18364900&_a=summary)

@mmlspark-bot
Copy link
Contributor

[A build has started. (3fa5939)](https://msazure.visualstudio.com/Cognitive Services/_build/index?buildId=18365946&_a=summary)

@mmlspark-bot
Copy link
Contributor

[A build has started. (a0d7a70)](https://msazure.visualstudio.com/Cognitive Services/_build/index?buildId=18366192&_a=summary)

@mmlspark-bot
Copy link
Contributor

[A build has started. (a0d7a70)](https://msazure.visualstudio.com/Cognitive Services/_build/index?buildId=18376339&_a=summary)

Adding files

Adding files

Adding files

Adding PySpark Evaluator Code Gen (attempt can't build locally)

Adding PySpark Evaluator Code Gen (working)

Adding PySpark Evaluator Code Gen (working)

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

Trying to fix formatting

dedup

dedup

dedup

dedup

dedup

dedup

dedup

dedup

dedup

dedup

Feedback

Feedback

Feedback
@mmlspark-bot
Copy link
Contributor

[A build has started. (a0d7a70)](https://msazure.visualstudio.com/Cognitive Services/_build/index?buildId=18376825&_a=summary)

@mmlspark-bot
Copy link
Contributor

[PASS Pass! — The build has succeeded. (d8bb798)](https://msazure.visualstudio.com/Cognitive Services/_build/index?buildId=18377523&_a=summary)

MMLSpark 0.14.dev26+1.gd8bb798

This is a build for Github PR #415, changes:


@mhamilton723 mhamilton723 merged commit 4a11367 into microsoft:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants