Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma is valid in query and doesn't need escaping #169

Closed
wants to merge 1 commit into from

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Jul 17, 2019

@johanste let's see what the CI (that includes testserver) will say

@lmazuel lmazuel changed the title Comme is valid in query and doesn't need escaping Comma is valid in query and doesn't need escaping Jul 17, 2019
@lmazuel
Copy link
Member Author

lmazuel commented Jul 17, 2019

HTTP spec RFC 3986:

   query         = *( pchar / "/" / "?" )

   pchar         = unreserved / pct-encoded / sub-delims / ":" / "@"

   pct-encoded   = "%" HEXDIG HEXDIG

   unreserved    = ALPHA / DIGIT / "-" / "." / "_" / "~"
   sub-delims    = "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" / "," / ";" / "="

@codecov-io
Copy link

codecov-io commented Jul 17, 2019

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          25       25           
  Lines        2583     2583           
=======================================
  Hits         2269     2269           
  Misses        314      314
Impacted Files Coverage Δ
msrest/serialization.py 91.03% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4086bf...a505530. Read the comment docs.

@johanste
Copy link
Member

We are still not escaping the individual items in the list. Which I would expect. And which we should have a test for. But, as you said, let's see what happens in the CI first :).

@lmazuel
Copy link
Member Author

lmazuel commented Dec 26, 2019

See #186 instead

@lmazuel lmazuel closed this Dec 26, 2019
@lmazuel lmazuel deleted the comma_query branch December 26, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants