Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Testing to src/pkg #316

Closed
jonathan-innis opened this issue Jun 13, 2021 · 3 comments · Fixed by #339
Closed

Add Unit Testing to src/pkg #316

jonathan-innis opened this issue Jun 13, 2021 · 3 comments · Fixed by #339
Assignees
@mahalrs
Labels
chore Chores size : L Feature / Enhancement that doesnt involve redesing
Projects
Orkestra
Milestone
Milestone #2

Comments

@jonathan-innis
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Our code coverage in controllers package is pretty high but the code coverage in the packages in the src/pkg directory is pretty bad. We need to write unit tests for these pieces to increase our code coverage
@jonathan-innis jonathan-innis added chore Chores size : L Feature / Enhancement that doesnt involve redesing labels Jun 13, 2021
@mahalrs
Copy link
Contributor

mahalrs commented Jun 13, 2021

I will work on this.

@jonathan-innis jonathan-innis added this to the v1beta1 milestone Jun 14, 2021
@nitishm nitishm added this to To Do in Orkestra Jun 14, 2021
@nitishm nitishm modified the milestones: v1beta1, Milestone #2 Jun 14, 2021
@mahalrs mahalrs mentioned this issue Jun 17, 2021
Merged
@helayoty helayoty moved this from To Do to In progress in Orkestra Jun 18, 2021
@mahalrs mahalrs mentioned this issue Jun 18, 2021
Merged
Orkestra automation moved this from In progress to Done Jun 20, 2021
@nitishm nitishm reopened this Jun 20, 2021
@nitishm
Copy link
Contributor

nitishm commented Jun 20, 2021

Partially addressed by #316

@mahalrs mahalrs mentioned this issue Jun 26, 2021
Closed
@jonathan-innis
Copy link
Contributor Author

@nitishm This is too large to be an "issue". We should break this into smaller tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahalrs mahalrs

Labels
chore Chores size : L Feature / Enhancement that doesnt involve redesing
Projects
Orkestra
  
Done
Milestone
Milestone #2
Development

Successfully merging a pull request may close this issue.

Refactor + unit tests for pkg/workflow/templates.go
3 participants
@nitishm @jonathan-innis @mahalrs