Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for pkg/workflow package #334

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Add unit tests for pkg/workflow package #334

merged 2 commits into from
Jun 23, 2021

Conversation

mahalrs
Copy link
Contributor

@mahalrs mahalrs commented Jun 17, 2021

partial #316

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #334 (3396ccf) into main (49631d9) will increase coverage by 0.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   38.10%   39.08%   +0.98%     
==========================================
  Files          14       14              
  Lines         811      811              
==========================================
+ Hits          309      317       +8     
+ Misses        491      483       -8     
  Partials       11       11              
Impacted Files Coverage Δ
pkg/workflow/graph.go 11.94% <100.00%> (+11.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49631d9...3396ccf. Read the comment docs.

@nitishm
Copy link
Contributor

nitishm commented Jun 23, 2021

@mahalrs can we merge this in even though it is partial? We can continue on a new PR for the same issue

@mahalrs mahalrs changed the title [WIP] Add unit tests for pkg/workflow package Add unit tests for pkg/workflow package Jun 23, 2021
@mahalrs
Copy link
Contributor Author

mahalrs commented Jun 23, 2021

@mahalrs can we merge this in even though it is partial? We can continue on a new PR for the same issue

Sure, will write rest of the units tests once I'm done with e2e parallel tests.

@mahalrs mahalrs marked this pull request as ready for review June 23, 2021 03:42
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, definitely need more graph_test test cases

@nitishm nitishm merged commit f33137a into Azure:main Jun 23, 2021
@mahalrs mahalrs deleted the test-pkg-workflow branch June 24, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants