Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debug Makefile Target and Debug mode for Controller #256

Merged
merged 5 commits into from
May 24, 2021

Conversation

jonathan-innis
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #256 (bb4ec59) into main (dcf446d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files           6        6           
  Lines        1016     1016           
=======================================
  Hits          324      324           
  Misses        664      664           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcf446d...bb4ec59. Read the comment docs.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
@nitishm
Copy link
Contributor

nitishm commented May 24, 2021

@jonathan-innis I added a commit to skip error if make debug is called twice, since re-creating a kind cluster would error out.
Also added a DEBUG_LEVEL env variable to control the log level.

Apart from that everything looks good. We can merge it!

Copy link
Contributor

@nitishm nitishm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants