Update application subcharts when subcharts are implicit #258
Conversation
…implicitly defined Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 31.88% 31.92% +0.03%
==========================================
Files 6 6
Lines 1016 1018 +2
==========================================
+ Hits 324 325 +1
- Misses 664 665 +1
Partials 28 28
Continue to review full report at Codecov.
|
controllers/appgroup_reconciler.go
Outdated
| @@ -99,7 +99,22 @@ func (r *ApplicationGroupReconciler) reconcileApplications(l logr.Logger, appGro | |||
| } | |||
|
|
|||
| if appCh.Dependencies() != nil { | |||
| isImplicitSubchartsList := false | |||
| // Update the application spec with a list of subcharts with no inter-dependence | |||
| if len(application.Spec.Subcharts) == 0 { | |||
There was a problem hiding this comment.
What happens if we specify some subcharts (but not all) and we want the ones not specified to not wait?
There was a problem hiding this comment.
Also, can you add a testcase for this scenario?
There was a problem hiding this comment.
Good point - I will add handlers for that case. Sure - will add testcases !
There was a problem hiding this comment.
@jonathan-innis I made the change and verified it manually. We still need to add tests for this scenario but I will track that in a separate issue since we need this to cut our next release. Let me know if that works and then I can create the other test issue
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
Fixes #257
Update application subcharts when subcharts are implicit
Signed-off-by: Nitish Malhotra nitish.malhotra@gmail.com