Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix logging command #1107

Merged
merged 2 commits into from Apr 4, 2023
Merged

docs: fix logging command #1107

merged 2 commits into from Apr 4, 2023

Conversation

ljtill
Copy link
Member

@ljtill ljtill commented Apr 1, 2023

Reason for Change:

Update troubleshooting guide for logging

  • Fix "secrets-store-provider-azure" label
  • Minor formatting change
  • List pods across all namespaces

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

Fix "secrets-store-provider-azure" label
Minor formatting change
List pods across all namespaces
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2023

Codecov Report

Merging #1107 (e7bc9e8) into master (e11dd11) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   56.34%   56.34%           
=======================================
  Files          10       10           
  Lines        1072     1072           
=======================================
  Hits          604      604           
  Misses        443      443           
  Partials       25       25           

@aramase
Copy link
Member

aramase commented Apr 4, 2023

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @ljtill! 🎉

LGTM

@aramase aramase merged commit d3bc4c3 into Azure:master Apr 4, 2023
11 checks passed
@ljtill ljtill deleted the patch-1 branch April 4, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants