New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodeaffinity vk #486
Nodeaffinity vk #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking into this. The changes look good, just one small nit:
- For chart or deployment yaml updates we update the yamls in the manifest_staging/ folder, where we host the staging charts and deployment yamls. All the yaml changes will then be promoted into the released charts folder with the next release.
- Also could you add the new configurable values to the configuration table.
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 64.31% 64.31%
=======================================
Files 7 7
Lines 510 510
=======================================
Hits 328 328
Misses 148 148
Partials 34 34 |
Thanks for the review @aramase . I have addressed above comments. Also added node affinity to deployment yamls. |
manifest_staging/charts/csi-secrets-store-provider-azure/README.md
Outdated
Show resolved
Hide resolved
manifest_staging/charts/csi-secrets-store-provider-azure/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reason for Change:
Change adds nodeaffinity to prevent scheduling on virtual-kubelet nodes.
Requirements
Issue Fixed:
#472
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:
Should we create new patch version(0.0.19) for chart?