Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodeaffinity vk #486

Merged
merged 6 commits into from
Apr 23, 2021
Merged

Nodeaffinity vk #486

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7368d9d
fix: adds nodeaffinity to prevent sheduling on VK
nilekhc Apr 23, 2021
645b60c
fix: updates helm template for windows
nilekhc Apr 23, 2021
e32cb2e
fix: moves changes to manifest_staging dir
nilekhc Apr 23, 2021
b20b705
docs: adds configurable values for nodeaffinity
nilekhc Apr 23, 2021
deb09ac
fix: adds nodeaffinity to deployment yamls
nilekhc Apr 23, 2021
362b588
docs: spell check
nilekhc Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions manifest_staging/charts/csi-secrets-store-provider-azure/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
| `linux.healthzTimeout` | RPC timeout for health check | `"5s"` |
| `linux.volumes` | Additional volumes to create for the KeyVault provider pods. | `[]` |
| `linux.volumeMounts` | Additional volumes to mount on the KeyVault provider pods. | `[]` |
| `linux.affinity` | Cofigures node affinity for provider pods on linux nodes | Match expression `type NotIn virtual-kubelet` |
nilekhc marked this conversation as resolved.
Show resolved Hide resolved
| `windows.enabled` | Install azure keyvault provider on windows nodes | false |
| `windows.image.repository` | Windows image repository | `mcr.microsoft.com/oss/azure/secrets-store/provider-azure` |
| `windows.image.pullPolicy` | Windows image pull policy | `IfNotPresent` |
Expand All @@ -88,6 +89,7 @@ The following table lists the configurable parameters of the csi-secrets-store-p
| `windows.healthzPath` | path for health check | `"/healthz"` |
| `windows.healthzTimeout` | RPC timeout for health check | `"5s"` |
| `windows.volumes` | Additional volumes to create for the KeyVault provider pods. | `[]` |
| `windows.affinity` | Cofigures node affinity for provider pods on windows nodes | Match expression `type NotIn virtual-kubelet` |
nilekhc marked this conversation as resolved.
Show resolved Hide resolved
| `windows.volumeMounts` | Additional volumes to mount on the KeyVault provider pods. | `[]` |
| `secrets-store-csi-driver.install` | Install secrets-store-csi-driver with this chart | true |
| `secrets-store-csi-driver.linux.enabled` | Install secrets-store-csi-driver on linux nodes | true |
Expand Down
2 changes: 2 additions & 0 deletions ...g/charts/csi-secrets-store-provider-azure/templates/provider-azure-installer-windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ spec:
{{- if .Values.windows.volumeMounts }}
{{- toYaml .Values.windows.volumeMounts | nindent 12 }}
{{- end}}
affinity:
{{ toYaml .Values.windows.affinity | indent 8 }}
{{- if .Values.windows.priorityClassName }}
priorityClassName: {{ .Values.windows.priorityClassName | quote }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions ...t_staging/charts/csi-secrets-store-provider-azure/templates/provider-azure-installer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ spec:
{{- if .Values.linux.volumeMounts }}
{{- toYaml .Values.linux.volumeMounts | nindent 12 }}
{{- end}}
affinity:
{{ toYaml .Values.linux.affinity | indent 8 }}
{{- if .Values.linux.priorityClassName }}
priorityClassName: {{ .Values.linux.priorityClassName | quote }}
{{- end }}
Expand Down
18 changes: 18 additions & 0 deletions manifest_staging/charts/csi-secrets-store-provider-azure/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,15 @@ linux:
healthzTimeout: "5s"
volumes: []
volumeMounts: []
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: type
operator: NotIn
values:
- virtual-kubelet

windows:
image:
Expand Down Expand Up @@ -77,6 +86,15 @@ windows:
healthzTimeout: "5s"
volumes: []
volumeMounts: []
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: type
operator: NotIn
values:
- virtual-kubelet

## Configuration values for the secrets-store-csi-driver dependency.
## ref: https://github.com/kubernetes-sigs/secrets-store-csi-driver/tree/master/charts/secrets-store-csi-driver/README.md
Expand Down
9 changes: 9 additions & 0 deletions manifest_staging/deployment/provider-azure-installer-windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,15 @@ spec:
- name: mountpoint-dir
mountPath: "C:\\var\\lib\\kubelet\\pods"
mountPropagation: HostToContainer
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: type
operator: NotIn
values:
- virtual-kubelet
volumes:
- name: providervol
hostPath:
Expand Down
9 changes: 9 additions & 0 deletions manifest_staging/deployment/provider-azure-installer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,15 @@ spec:
- name: mountpoint-dir
mountPath: /var/lib/kubelet/pods
mountPropagation: HostToContainer
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: type
operator: NotIn
values:
- virtual-kubelet
volumes:
- name: providervol
hostPath:
Expand Down