fix: runs msi-adapter as privileged on openshift #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
=======================================
Coverage 62.15% 62.15%
=======================================
Files 9 9
Lines 909 909
=======================================
Hits 565 565
Misses 311 311
Partials 33 33 |
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
|
/azp run pr-e2e-azure |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aramase
reviewed
Jun 21, 2022
aramase
reviewed
Jun 21, 2022
There was a problem hiding this comment.
@nilekhc could you open a separate PR to fix CVE-2022-28948 with gopkg.in/yaml.v3? That way the PR gate is unblocked and also this PR won't be a scope creep
5 tasks
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@aramase I was successfully able to test changes on ARO cluster.
|
aramase
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com
Reason for Change:
MSI-Adapter container needs to run as privileged when deploying Arc extension on openshift. Similar guidance we follow for provider pods as well.
Requirements
Issue Fixed:
fixes: #921
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: