Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: helm chart release for driver v1.2.0 #923

Merged
merged 1 commit into from Jun 28, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Jun 22, 2022

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

  • Yes
  • No

If "Yes," did you notify that project's maintainers and provide attribution?

Special Notes for Reviewers:

@aramase
Copy link
Member Author

aramase commented Jun 22, 2022

/azp run pr-e2e-azure

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nilekhc
Copy link
Contributor

nilekhc commented Jun 22, 2022

@aramase Could we please hold this PR until ARO changes are in?

Ref: #920

@nilekhc
Copy link
Contributor

nilekhc commented Jun 28, 2022

@aramase Could we please hold this PR until ARO changes are in?

Ref: #920

@aramase We are good with proceeding on this PR. Let's rerun chart release to get ARO changes as well.

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #923 (7022c8c) into master (2eee8b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   62.15%   62.15%           
=======================================
  Files           9        9           
  Lines         909      909           
=======================================
  Hits          565      565           
  Misses        311      311           
  Partials       33       33           

@aramase
Copy link
Member Author

aramase commented Jun 28, 2022

/azp run pr-e2e-azure

@aramase aramase marked this pull request as ready for review June 28, 2022 17:20
@aramase aramase requested a review from nilekhc as a code owner June 28, 2022 17:20
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aramase aramase merged commit c34cd85 into Azure:master Jun 28, 2022
@aramase aramase deleted the driver-v1.2.0 branch June 28, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants