[Celestica] Fix platform module to be compatible with Python3 #10051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lukasstockner
force-pushed
the
seastone-2-platform-fix
branch
2 times, most recently
from
c68057d
to
a749dea
Compare
Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
lukasstockner
force-pushed
the
seastone-2-platform-fix
branch
from
a749dea
to
c5bb357
Compare
|
This pull request introduces 4 alerts when merging c5bb357 into 10f36d6 - view on LGTM.com new alerts:
|
False positive, it's confusing two different |
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Feb 3, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Feb 19, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Feb 19, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Mar 3, 2024
bluecmd
added a commit
to kamelnetworks/sonic-buildimage
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Running a current build of master or any of the recent release branches on a Seastone2 switch (and presumably other Celestica switches, since the code in question is shared) results in lots of errors in the logs and many platform-level commands not working as expected since the underlying platform module is not updated for Python 3 yet.
How I did it
By checking through the logs and trying out platform-related commands (e.g. showing SFP EEPROM info), I've identified some issues in the code. Most are related to Python 3 compatibility (includes and bytestring handling).
Together with #9770, this solves all platform issues that I found.
Therefore, this also fixes #8212.
How to verify it
Build the current master image, run it on a Seastone2, observe lots of platform-module-related errors in the syslog.
Build an image containing #9770 and this PR, run it on a Seastone2, check the syslog to see that the errors are gone.
Which release branch to backport (provide reason below if selected)
These three releases are affected by #8212, so they should receive this fix.
Note that when backporting,
vendor_revshould be changed tohardware_revsince #9447 is not part of the release branches.Description for the changelog
Fix Celestica platform module to be compatible with Python3.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)