Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When enabled, PINS/p4rt is not generated, it is generated only for bullseye, hence c version errors #10127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mfyuce
Copy link

@mfyuce mfyuce commented Mar 2, 2022

  • PINS only runs on buster, and because of this makefile bug, it is only generated for bullseye to be run on buster.
  • Also required buster libgmp-dev dependency for p4rt binary running in docker-sonic-p4rt container was not provided. It is added (this bug surfaced when running p4rt binary inside docker. Teh error said "cannot find libgmpxx.so.4 dependency")

Related to issue : #9885

Why I did it

I could not build SONIC with p4rt enabled. When I succeeded building, generated docker would be buster but the p4rt bin inside would be bullseye.

How I did it

Added two line to the respective p4rt make file

How to verify it

Follow PINS build instructions at here (in current state with master it is not working without this fix)

Which release branch to backport (provide reason below if selected)

202111: Because on the public anouncements, PINS said to be entegrated to this branch

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

  • Added two lines, for p4rt make files to be integrated to the buster build
  • Added required buster libgmp-dev dependency for p4rt binary running in docker-sonic-p4rt container.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

:)
image

PINS only runs on buster and because of this bug, it does not run on buster and only on bullseye.

Related to issue number: sonic-net#9885
@mfyuce mfyuce changed the title disable bullseye for PINS/p4rt -> p4rt fails PINS/p4rt not generated when enabled, it is generated only for bullseye, hence c version errors Mar 2, 2022
@mfyuce mfyuce changed the title PINS/p4rt not generated when enabled, it is generated only for bullseye, hence c version errors When enabled, PINS/p4rt is not generated, it is generated only for bullseye, hence c version errors Mar 2, 2022
Added required libgmp-dev dependency for p4rt binary running in docker-sonic-p4rt container.
@ghost
Copy link

ghost commented Mar 3, 2022

CLA assistant check
All CLA requirements met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant