VS image build failed when P4RT container is enabled

[zhangineer2]

Description

Steps to reproduce the issue:

1. Proceed with the normal building process to choose PLATFORM=vs
2. Execute make SONIC_BUILD_JOBS=4 INSTALL_DEBUG_TOOLS=y target/sonic-vs.bin

Describe the results you received:

ERROR: invalid type '' for SAI_ACL_COUNTER_ATTR_TABLE_ID
ERROR: flags are not defined for SAI_ACL_COUNTER_ATTR_TABLE_ID
ERROR: FATAL ERROR === MUST FIX === : Can't use an undefined value as an ARRAY reference at parse.pl line 1676.

make[4]: *** [Makefile:107: saimetadata.c] Error 1
make[4]: Leaving directory '/sonic/src/sonic-sairedis/SAI/meta'
make[3]: *** [Makefile:1144: saimeta-gen] Error 2
make[3]: Leaving directory '/sonic/src/sonic-sairedis/meta'
make[2]: *** [Makefile:444: install-recursive] Error 1
make[2]: Leaving directory '/sonic/src/sonic-sairedis'
dh_auto_install: error: make -j1 install DESTDIR=/sonic/src/sonic-sairedis/debian/tmp AM_UPDATE_INFO_DIR=no returned exit code 2
make[1]: *** [debian/rules:59: binary-syncd-vs] Error 25
make[1]: Leaving directory '/sonic/src/sonic-sairedis'
dpkg-buildpackage: error: fakeroot debian/rules binary-syncd-vs subprocess returned exit status 2
[ FAIL LOG END ] [ target/debs/bullseye/libsairedis_1.0.0_amd64.deb ]
make: *** [slave.mk:511: target/debs/bullseye/libsairedis_1.0.0_amd64.deb] Error 1
make: *** Waiting for unfinished jobs....
[ 01 ] [ target/debs/bullseye/linux-headers-5.10.0-8-2-common_5.10.46-4_all.deb ]
make[1]: *** [Makefile.work:311: target/sonic-vs.bin] Error 2
make[1]: Leaving directory '/home/sonic/sonic-buildimage'
make: *** [Makefile:33: target/sonic-vs.bin] Error 2

Describe the results you expected:

Expected no errors with successful image build. When I disabled the P4RT container, the image build process went through successfully.

[zhangyanzhao]

PINS is an opt-in feature, this should not happen if you disable it. Need PINS member to take a look.

[prsunny]

@mint570, @donNewtonAlpha, @reshmaintel to take a look

[mint570]

How did you enable/disable the P4RT container?
The build error is in src/sonic-sairedis. Doesn't seem to relate to P4RT.

[zhangineer2]

How did you enable/disable the P4RT container? The build error is in src/sonic-sairedis. Doesn't seem to relate to P4RT.

I enabled it through config file, by changing P4RT from no to yes

[zhangineer2]

Hey guys, I run into a different issue as I am testing to disable various containers but leave P4RT on, because that's what I really need.

I received the following error, but with no helpful details. I do have the debug set to y. My question is, where can I dig into the logs to really see what's happening?

Installing collected packages: jsonschema, sonic-platform-pddf-common
  WARNING: The script jsonschema is installed in '/var/sonic/.local/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed jsonschema-2.6.0 sonic-platform-pddf-common-1.0
WARNING: You are using pip version 21.3.1; however, version 22.0.3 is available.
[ 01 ] [ target/debs/bullseye/linux-headers-5.10.0-8-2-common_5.10.46-4_all.deb ]
[ 02 ] [ target/debs/bullseye/libnl-3-200_3.5.0-1_amd64.deb ]
make[1]: *** [Makefile.work:311: all] Error 2
make[1]: Leaving directory '/home/sonic/sonic-buildimage'

[MaratGubaiev]

I cannot say for sure, but you may try to use their fork https://github.com/pins/sonic-buildimage-public
I have been trying to use PINS myself on the Mellanox platform, and I have as well stuck in build problems: I have got a p4rt container but it doesn't work. Now I am trying to do what I proposed: to build the fork! UPD I have got build errors(((((

[MaratGubaiev]

I tried to build sonic-vs too, and build succeeded.
Build server: Ubuntu 20.04.1 LTS
Branch: 202111 of main repo with INCLUDE_P4RT = y in rules/config
Build command: make init && make configure PLATFORM=vs SONIC_DPKG_CACHE_METHOD=cache SONIC_DPKG_CACHE_SOURCE=/nfs/dpkg_cache/vs && make SONIC_BUILD_JOBS=4 SONIC_DPKG_CACHE_METHOD=cache SONIC_DPKG_CACHE_SOURCE=/nfs/dpkg_cache/vs target/docker-sonic-vs.gz target/sonic-vs.img.gz target/docker-ptf.gz

NOTE: I have not checked how it works yet, because I have just got it.

UPD: p4rt container is præsent but it doesn't work because of С&С++ versions incompatibility. PINS member are going to fix this issue.

[zhangineer2]

Thank you @MaratGubaiev !. I got farther than before using your setup. I ended up with a .img and a .bin file, though I still received some error.

Thank you for the update on the C incompatibility issue !

[mfyuce]

UPD: p4rt container is præsent but it doesn't work because of С&С++ versions incompatibility. PINS member are going to fix this issue.

I have tried many times, no luck so far for a working p4rt container;

• p4rt container is based on buster.
• But the software inside is compiled on bullseye.
• Disabling bullseye + stretch+jessie and enabling p4rt in turn requires jessie to be enabled. But, even after enabling jessie, no p4rt image is generated for buster build.
• This is true in 202111 branch also.