Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Celestica] Midstone-100x platform changes #12117

Open
wants to merge 7 commits into
base: 202111
Choose a base branch
from

Conversation

praveenraja1
Copy link

Why I did it

Midstone-100x support addition for 202111 - Innovium chip has started supporting community Sonic 202111 with its latest SAI.

How I did it

  1. Adding bullseye changes for the midstone platform drivers.
  2. Modify midstone platform parameters like fan/psu/sfp to adhere to 202111 architecture like fan_drawer etc.

How to verify it

verified by SONiC tested platform APIs
verified by SONiC APIs including " psuutil
psushow(show platform psustatus)
sfputil
sfpshow
tempershow(show platform temperature)
fanshow(show platform fan)
watchdogutil
fwutil(show platform firmware status)
decode-syseeprom -d(show platform syseeprom)
show platform ssdhealth
show platform summary

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 20, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@praveenraja1 praveenraja1 changed the title Midstone-100x platform changes [Celestica] Midstone-100x platform changes Sep 20, 2022
@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2022

This pull request introduces 4 alerts when merging 4406ffc into fc04f74 - view on LGTM.com

new alerts:

  • 1 for Module imports itself
  • 1 for Unused local variable
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2022

This pull request introduces 2 alerts when merging 8dffdbb into fc04f74 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2022

This pull request introduces 2 alerts when merging e0e8878 into fc04f74 - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Wrong number of arguments in a class instantiation

@xumia
Copy link
Collaborator

xumia commented Oct 11, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2022

This pull request introduces 1 alert when merging a7a9501 into 45b403d - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2022

This pull request introduces 1 alert when merging 63f2370 into c500f5d - view on LGTM.com

new alerts:

  • 1 for Wrong number of arguments in a class instantiation

@praveenraja1
Copy link
Author

Looks like there is a broadcom image build failure,

"
The following packages have unmet dependencies:
python3-dev : Depends: libpython3-dev (= 3.7.3-1) but it is not going to be installed Depends: python3.7-dev (>= 3.7.3-1~) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.
"

The private branch '202111-midstone_commit' (from which the merge request is generated) is already synced to the latest 202111. And all the merge request changes are contained within platform 'innovium'. So this could be infra issue, need to investigate.

@zhangyanzhao
Copy link
Collaborator

Per TSC guidance, this PR should be merged into master branch instead of 202111 branch only. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants