Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] fix DPKG cache for frr #17475

Merged
merged 1 commit into from May 19, 2024
Merged

Conversation

k-v1
Copy link
Contributor

@k-v1 k-v1 commented Dec 11, 2023

Why I did it

Fix #16713
Variable SMDEP_FILES is empty and smdep file is not generated for sonic-frr.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Need to escape a dollar sign in Makefiles.

How to verify it

Rebuild frr with build cache and make sure smdep file for sonic-frr exists in target.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@qiluo-msft
Copy link
Collaborator

@xumia Please help review.

Copy link
Collaborator

@xumia xumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-v1
Copy link
Contributor Author

k-v1 commented Dec 31, 2023

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@k-v1
Copy link
Contributor Author

k-v1 commented Jan 13, 2024

@qiluo-msft

Is it possible to merge this PR? It has been approved and all checks have passed.

@lguohan lguohan merged commit 6164d58 into sonic-net:master May 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants