[build]Fix FRR build cache issue #16713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
11 tasks
|
@xumia @qiluo-msft Can you please help merge? |
|
@dgsudharsan PR conflicts with 202305 branch |
StormLiangMS
added
Approved for 202305 Branch
and removed
Cherry Pick Conflict_202305
Approved for 202305 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 10, 2023
### Why I did it When FRR is built with Cache enabled, the build failed with the following error logs ``` [2023-09-20T15:17:00.273Z] fatal: Unable to hash src/sonic-frr/frr/tests/topotests/grpc_basic/lib [2023-09-20T15:17:00.273Z] fatal: Unable to hash src/sonic-frr/frr/tests/topotests/ospfapi/lib [2023-09-20T15:17:00.273Z] make: *** [Makefile.cache:528: target/debs/bullseye/frr_8.5.1-sonic-0_amd64.deb.smdep] Error 123 [2023-09-20T15:17:00.273Z] make: *** Waiting for unfinished jobs.... ``` #### How I did it Currently symlinks are excluded in hardcoded fashion. With FRR upgrades new symlinks might get introduced. To overcome it modified the way in which symlinks are excluded by finding symlinks using find command #### How to verify it Build FRR with cache enabled
|
Cherry-pick PR to 202305: #16823 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 10, 2023
### Why I did it When FRR is built with Cache enabled, the build failed with the following error logs ``` [2023-09-20T15:17:00.273Z] fatal: Unable to hash src/sonic-frr/frr/tests/topotests/grpc_basic/lib [2023-09-20T15:17:00.273Z] fatal: Unable to hash src/sonic-frr/frr/tests/topotests/ospfapi/lib [2023-09-20T15:17:00.273Z] make: *** [Makefile.cache:528: target/debs/bullseye/frr_8.5.1-sonic-0_amd64.deb.smdep] Error 123 [2023-09-20T15:17:00.273Z] make: *** Waiting for unfinished jobs.... ``` #### How I did it Currently symlinks are excluded in hardcoded fashion. With FRR upgrades new symlinks might get introduced. To overcome it modified the way in which symlinks are excluded by finding symlinks using find command #### How to verify it Build FRR with cache enabled
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
lguohan
pushed a commit
that referenced
this pull request
May 19, 2024
Fix #16713 Variable SMDEP_FILES is empty and smdep file is not generated for sonic-frr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
When FRR is built with Cache enabled, the build failed with the following error logs
Work item tracking
How I did it
Currently symlinks are excluded in hardcoded fashion. With FRR upgrades new symlinks might get introduced. To overcome it modified the way in which symlinks are excluded by finding symlinks using find command
How to verify it
Build FRR with cache enabled
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)