fix show environment for n3248te #17508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@arunlk-dell @vpsubramaniam please review! |
justindthomas
force-pushed
the
fix-dell
branch
from
4630bb1
to
c4c56a2
Compare
arunlk-dell
approved these changes
Dec 15, 2023
vpsubramaniam
approved these changes
Dec 15, 2023
|
@lguohan is this ready to review? |
justindthomas
added a commit
to justindthomas/sonic-buildimage
that referenced
this pull request
Mar 25, 2024
Why I did it The command show environment has been broken on this platform for quite a while. These adjustments allow it to function again. How I did it I adjusted the platform_sensors.py file for the n3248te to appease the errors that it was generating from the Python interpreter. How to verify it Run sudo show environment on an unchanged n3248te to see that it generates an error right away about print statements being malformed. Then place this file at /usr/bin/platform_sensors.py in the pmon container and run the command again to see the correct output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The command
show environmenthas been broken on this platform for quite a while. These adjustments allow it to function again.Work item tracking
How I did it
I adjusted the
platform_sensors.pyfile for the n3248te to appease the errors that it was generating from the Python interpreter.How to verify it
Run
sudo show environmenton an unchanged n3248te to see that it generates an error right away aboutprintstatements being malformed. Then place this file at/usr/bin/platform_sensors.pyin thepmoncontainer and run the command again to see the correct output.Tested branch (Please provide the tested image version)
master
Description for the changelog
Updated platform_sensors.py for the Dell N3248TE-ON platform to fix Python errors.