Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix show environment for n3248te #17508

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

justindthomas
Copy link
Contributor

Why I did it

The command show environment has been broken on this platform for quite a while. These adjustments allow it to function again.

Work item tracking
  • Microsoft ADO (number only):

How I did it

I adjusted the platform_sensors.py file for the n3248te to appease the errors that it was generating from the Python interpreter.

How to verify it

Run sudo show environment on an unchanged n3248te to see that it generates an error right away about print statements being malformed. Then place this file at /usr/bin/platform_sensors.py in the pmon container and run the command again to see the correct output.

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

master

Description for the changelog

Updated platform_sensors.py for the Dell N3248TE-ON platform to fix Python errors.

Copy link

linux-foundation-easycla bot commented Dec 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: justindthomas / name: Justin Thomas (c4c56a2)

@jeff-yin
Copy link
Collaborator

@arunlk-dell @vpsubramaniam please review!

@SkylarHoughtonIntelerad

@lguohan is this ready to review?

@lguohan lguohan merged commit fb29a40 into sonic-net:master Mar 25, 2024
9 checks passed
justindthomas added a commit to justindthomas/sonic-buildimage that referenced this pull request Mar 25, 2024
Why I did it
The command show environment has been broken on this platform for quite a while. These adjustments allow it to function again.

How I did it
I adjusted the platform_sensors.py file for the n3248te to appease the errors that it was generating from the Python interpreter.

How to verify it
Run sudo show environment on an unchanged n3248te to see that it generates an error right away about print statements being malformed. Then place this file at /usr/bin/platform_sensors.py in the pmon container and run the command again to see the correct output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants