Dev cli sessions #17623
Dev cli sessions #17623
Conversation
i-davydenko
force-pushed
the
dev-cli-sessions
branch
2 times, most recently
from
ea0b9f3
to
9e2bdcf
Compare
|
Hi @lguohan , Hi @qiluo-msft |
| @@ -40,6 +45,20 @@ module sonic-ssh-server { | |||
| } | |||
| } | |||
| } | |||
| leaf inactivity_timeout { | |||
| description "inactivity timeout (in minutes), 0 means no timeout"; | |||
| default 15; | |||
There was a problem hiding this comment.
@qiluo-msft hi, yes, this is old defaults in sonic
| type int32 { | ||
| range "0..35000"; | ||
| } | ||
| default 15; |
There was a problem hiding this comment.
@qiluo-msft hi, yes, this is old defaults in sonic
| @@ -0,0 +1,37 @@ | |||
| //filename: sonic-serial-console.yang | |||
| module sonic-serial-console { | |||
There was a problem hiding this comment.
@ganglyu @wen587 @isabelmsft Please help review the 2 Yang models.
There was a problem hiding this comment.
@i-davydenko
Can you create separate PR for sonic yang models?
There was a problem hiding this comment.
@i-davydenko is there a PR for yang? can you please share?
also please add it to the HLD list of PRs for the feature
|
|
||
| leaf sysrq_capabilities { | ||
| description "managing SysRq capabilities"; | ||
| type enumeration { |
There was a problem hiding this comment.
…ded ssh-server tree.
update tests for ssh-server model
i-davydenko
force-pushed
the
dev-cli-sessions
branch
from
0b58b74
to
4a4aa75
Compare
|
Please reduce the "force-pushed" usage, which invalidated all the previous review status. |
|
@qiluo-msft not sure how to handle ms_conflict — MS conflict detect. Could you please advise what should I do? |
sonic-net/SONiC#1367
Why I did it
Give ability to:
Work item tracking
Microsoft ADO (number only):
How I did it
Add new service that responsible for serial configuration;
Update existing flows for extended ssh-server configurations in hostcfgd;
Add YANG model to support new configuration.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
ssh_server
serial_console
A picture of a cute animal (not mandatory but encouraged)
kitty - Cube