feat: Configure await timeout before connecting to a dev server #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgollapudi77
requested review from
annaji-msft,
anthonychu and
manekinekko
as code owners
github-actions
bot
added
scope: cli
|
|
|
@manekinekko can you please check the PR once and tell me if I need to add some checks (or) do I need to change some naming convention (or) anything at all. |
manekinekko
requested changes
Jul 9, 2021
src/core/utils/net.ts
Outdated
| //The argument 10 implies to convert the given string to base-10(decimal) | ||
| const timeValue = parseInt(time, 10); | ||
| if (isNaN(timeValue)) { | ||
| logger.error(`Time "${time} is not a number.`, true); |
There was a problem hiding this comment.
Suggested change
| logger.error(`Time "${time} is not a number.`, true); | |
| logger.error(`--devserser-timeout should be a number expressed in milliseconds. Got "${time}".`, true); |
There was a problem hiding this comment.
Updated the same
src/core/utils/net.ts
Outdated
| @@ -157,3 +157,12 @@ export function hostnameToIpAdress(hostnameOrIpAddress: string | undefined) { | |||
| } | |||
| return hostnameOrIpAddress; | |||
| } | |||
|
|
|||
| export function parseTime(time: string) { | |||
There was a problem hiding this comment.
Suggested change
| export function parseTime(time: string) { | |
| export function parseDevServerTimeout(time: string) { |
There was a problem hiding this comment.
Updated the same
src/core/utils/net.ts
Outdated
| @@ -157,3 +157,12 @@ export function hostnameToIpAdress(hostnameOrIpAddress: string | undefined) { | |||
| } | |||
| return hostnameOrIpAddress; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This function should be moved to src/core/utils/cli.ts and must be tested.
There was a problem hiding this comment.
Updated and added tests
|
I left a few comments but overall looks great! |
|
@manekinekko I've made changes but made a mistake of pushing 2 commits to this PR. |
manekinekko
approved these changes
Jul 12, 2021
|
LGTM |
manekinekko
added
the
pr: lgtm
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #253
Allows user to configure wait timeout before dev server starts using the flag
--devserver-timeout, such as:swa start --devserver-timeout 10000