Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix firewall policy association #53

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Bug fix firewall policy association #53

merged 3 commits into from
Apr 24, 2024

Conversation

pagyP
Copy link
Contributor

@pagyP pagyP commented Apr 3, 2024

Description

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in locals.version.tf.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in locals.version.tf.json.
    • Breaking changes and I have bumped the MAJOR version in locals.version.tf.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

matt-FFFFFF
matt-FFFFFF reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@matt-FFFFFF matt-FFFFFF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Otherwise lgtm

examples/firewall-linked-firewall-policy/.terraform-docs.yml Outdated Show resolved Hide resolved
@philipstreet philipstreet mentioned this pull request Apr 23, 2024
Closed
khushal08
khushal08 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@khushal08 khushal08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khushal08 khushal08 merged commit e289aed into Azure:main Apr 24, 2024
6 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-FFFFFF matt-FFFFFF matt-FFFFFF left review comments

@khushal08 khushal08 khushal08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pagyP @matt-FFFFFF @khushal08