Change images "required" value #302
Conversation
Setting the `images` input as required is causing validation errors in my GitHub Actions extension. Per the description, it seems like the value should actually be set to `required: false`
benjaminmillhouse
requested review from
kaverma,
kanika1894 and
BALAGA-GAYATRI
as code owners
benjaminmillhouse
temporarily deployed
to
automation test
GitHub Actions
Inactive
benjaminmillhouse
temporarily deployed
to
automation test
GitHub Actions
Inactive
|
@benjaminmillhouse could you please share your workflow yam and use case which you are trying to run? |
Sure - I am doing a zip-based deploy to an Azure App Service
I am able to run the workflow still, but the GitHub Actions extension in VS Code is highlighting an error that I am missing the "images" property since it has been defined as required in the metadata
|
|
+1 - ZIP deploy and the error squiggle from the required parameter with the VSCode GitHub Actions extension:
|
|
+1 Reproduce by using GitHub Actions for VS Code with any workflow using webapps-deploy. |
|
This PR is idle because it has been open for 14 days with no activity. |
|
Fixes #307 |
|
Came from github/vscode-github-actions#58. This should be approved! |
Setting the
imagesinput as required is causing validation errors in my GitHub Actions extension. Per the description, it seems like the value should actually be set torequired: falseThis Pull Request sets the required status to false instead of true.