Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated fix for controlling depth. #2024

Merged
merged 1 commit into from Feb 15, 2023
Merged

Conversation

brentschmaltz
Copy link
Member

Picks up a fix for controlling depth of parsing.

@TimHannMSFT
Copy link
Contributor

Since we fork newtonsoft do we normally pull in their tests too are do we assume we'd catch a regression here another way --OR-- are we simply saying that since since we don't intend to touch this code we're relying on the newtonsoft tests running in their repo?

Other than that LGTM. I think generally if we have the code in our repo we should have the tests in our repo too.

@brentschmaltz
Copy link
Member Author

@TimHannMSFT i didn't see any test code for NewtonSoft in our branch.

@brentschmaltz brentschmaltz merged commit dc66295 into dev Feb 15, 2023
@brentschmaltz brentschmaltz deleted the brentsch/NewtonsoftUpdate branch February 23, 2023 18:24
renovate bot added a commit to orso-co/Orso.Arpa.Api that referenced this pull request Apr 7, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[System.IdentityModel.Tokens.Jwt](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet)
| nuget | minor | `6.27.0` -> `6.28.1` |

---

### Release Notes

<details>

<summary>AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet</summary>

###
[`v6.28.1`](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/6.28.1)

[Compare
Source](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/6.28.0...6.28.1)

- Bug fix where internal cache was not instantiated
[AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2045

###
[`v6.28.0`](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/6.28.0)

[Compare
Source](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/6.27.0...6.28.0)

- Enrich metadata failure message during metadata refresh interval
[AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2010
- Updated fix for controlling depth
[AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2024
- Update Wilson logs with aka.ms pointers to known wikis in
[AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2027
- Fix typo in documentation
[AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2034
- Introduce a LKG configuration cache to store each valid base
configuration instead of a single entry of configuration
[AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2007
- Add encryption keys to base configuration
[AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2023
- Updated CHANGELOG link
[AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#2026

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge -
At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/orso-co/Orso.Arpa.Api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants