Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop azureauth before install #99

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Stop azureauth before install #99

merged 1 commit into from
Jun 9, 2022

Conversation

reillysiemens
Copy link
Member

Installation can fail if azureauth is running at the same time. This will attempt to stop azureauth first. We tried to add this in #93, but had to revert it in #95. Using a try/catch block now prevents this from triggering $ErrorActionPreference='Stop' in PowerShell 5.

@reillysiemens reillysiemens requested a review from a team as a code owner June 9, 2022 18:34
@reillysiemens reillysiemens added the bug Something isn't working label Jun 9, 2022
@reillysiemens reillysiemens self-assigned this Jun 9, 2022
@reillysiemens reillysiemens force-pushed the stop-azureauth-before-install branch from 59e19b0 to 4de51f0 Compare June 9, 2022 18:36
@reillysiemens reillysiemens force-pushed the stop-azureauth-before-install branch from 4de51f0 to 7127850 Compare June 9, 2022 18:44
goagain
goagain approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@goagain goagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on Win2012, but I am still wondering if there is a more graceful way to implement. Using an empty try-catch block seems a little bit ugly. 😅

varshini-elayappen
varshini-elayappen approved these changes Jun 9, 2022
View reviewed changes
Copy link

@varshini-elayappen varshini-elayappen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@reillysiemens
Copy link
Member Author

@goagain: I absolutely agree that using an empty catch block here is a little ugly. If you find a better solution I would be happy to accept it in a PR. 😎

@reillysiemens reillysiemens merged commit 412db46 into main Jun 9, 2022
@reillysiemens reillysiemens deleted the stop-azureauth-before-install branch June 9, 2022 19:09
@goagain goagain mentioned this pull request Jun 9, 2022
Merged
@reillysiemens reillysiemens mentioned this pull request Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-rader kyle-rader kyle-rader approved these changes

@goagain goagain goagain approved these changes

@varshini-elayappen varshini-elayappen varshini-elayappen approved these changes

Assignees

@reillysiemens reillysiemens

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reillysiemens @kyle-rader @goagain @varshini-elayappen